Chat input area component #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
approved these changes
Jan 9, 2024
| }; | ||
| } | ||
|
|
||
| export default class OnKeyModifier extends Modifier<Signature> {} |
There was a problem hiding this comment.
If we produce enough of these maybe we can just do this 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Kept the hover and focus states to remain consistent with rest of boxel inputs and also for better accessibility
2-
Pressing "enter" submits the text and "shift enter" creates a line break.Just noticed that in one of the designs it says "cmd enter" should submit the text, I will update. Updated:cmd+Enterorctrl+Entersubmits the message.entercreates line breaks.3- The trick I used to expand textarea only works when there are line breaks. the only other way to do this without line breaks requires not using a
textareabut casting a generic element as a contenteditable textbox, which is not great for accessibility and does not come with all the bindings.From the ticket [CS 6424]:
hover state:
focus state:
no scroll up to 5 lines:
scrolls over 5 lines:
